-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues #206651
[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues #206651
Conversation
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯 (Code review only)
Starting backport for target branches: 7.17, 8.16, 8.17, 8.x |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…elastic#206651) ## Summary `cytoscape` released yet another semver breaking change, affecting typing once more in a couple of places. They now have their own `index.d.ts` file for Typescript support, but this causes some issues as they don't always have the same type name as the `@types` version. Had to fix in a couple of places, both in APM and in ML codebases. Supersedes elastic#206498 ## How to test * This PR passes the CI with no typing issues, or failed tests * Going to APM or ML pages with cytoscape being loaded shows no regressions.
…elastic#206651) ## Summary `cytoscape` released yet another semver breaking change, affecting typing once more in a couple of places. They now have their own `index.d.ts` file for Typescript support, but this causes some issues as they don't always have the same type name as the `@types` version. Had to fix in a couple of places, both in APM and in ML codebases. Supersedes elastic#206498 ## How to test * This PR passes the CI with no typing issues, or failed tests * Going to APM or ML pages with cytoscape being loaded shows no regressions.
…elastic#206651) ## Summary `cytoscape` released yet another semver breaking change, affecting typing once more in a couple of places. They now have their own `index.d.ts` file for Typescript support, but this causes some issues as they don't always have the same type name as the `@types` version. Had to fix in a couple of places, both in APM and in ML codebases. Supersedes elastic#206498 ## How to test * This PR passes the CI with no typing issues, or failed tests * Going to APM or ML pages with cytoscape being loaded shows no regressions. (cherry picked from commit a0bdc19) # Conflicts: # package.json # x-pack/plugins/observability_solution/apm/public/components/app/service_map/cytoscape_options.ts # yarn.lock
…elastic#206651) ## Summary `cytoscape` released yet another semver breaking change, affecting typing once more in a couple of places. They now have their own `index.d.ts` file for Typescript support, but this causes some issues as they don't always have the same type name as the `@types` version. Had to fix in a couple of places, both in APM and in ML codebases. Supersedes elastic#206498 ## How to test * This PR passes the CI with no typing issues, or failed tests * Going to APM or ML pages with cytoscape being loaded shows no regressions. (cherry picked from commit a0bdc19) # Conflicts: # package.json # x-pack/plugins/apm/public/components/app/service_map/cytoscape_options.ts # x-pack/plugins/ml/public/application/data_frame_analytics/pages/job_map/components/cytoscape.tsx # yarn.lock
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…issues (#206651) (#207214) # Backport This will backport the following commits from `main` to `8.x`: - [[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)](#206651) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2025-01-20T13:36:22Z","message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues","number":206651,"url":"https://github.com/elastic/kibana/pull/206651","mergeCommit":{"message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206651","number":206651,"mergeCommit":{"message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5"}}]}] BACKPORT-->
… issues (#206651) (#207224) # Backport This will backport the following commits from `main` to `8.16`: - [[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)](#206651) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2025-01-20T13:36:22Z","message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues","number":206651,"url":"https://github.com/elastic/kibana/pull/206651","mergeCommit":{"message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206651","number":206651,"mergeCommit":{"message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5"}}]}] BACKPORT-->
… issues (#206651) (#207223) # Backport This will backport the following commits from `main` to `8.17`: - [[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)](#206651) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2025-01-20T13:36:22Z","message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues","number":206651,"url":"https://github.com/elastic/kibana/pull/206651","mergeCommit":{"message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206651","number":206651,"mergeCommit":{"message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5"}}]}] BACKPORT-->
… issues (#206651) (#207230) # Backport This will backport the following commits from `main` to `7.17`: - [[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)](#206651) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2025-01-20T13:36:22Z","message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues","number":206651,"url":"https://github.com/elastic/kibana/pull/206651","mergeCommit":{"message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206651","number":206651,"mergeCommit":{"message":"[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues (#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver breaking change, affecting\r\ntyping once more in a couple of places. They now have their own\r\n`index.d.ts` file for Typescript support, but this causes some issues as\r\nthey don't always have the same type name as the `@types` version. Had\r\nto fix in a couple of places, both in APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to test\r\n\r\n* This PR passes the CI with no typing issues, or failed tests\r\n* Going to APM or ML pages with cytoscape being loaded shows no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5"}}]}] BACKPORT-->
…elastic#206651) ## Summary `cytoscape` released yet another semver breaking change, affecting typing once more in a couple of places. They now have their own `index.d.ts` file for Typescript support, but this causes some issues as they don't always have the same type name as the `@types` version. Had to fix in a couple of places, both in APM and in ML codebases. Supersedes elastic#206498 ## How to test * This PR passes the CI with no typing issues, or failed tests * Going to APM or ML pages with cytoscape being loaded shows no regressions.
…elastic#206651) ## Summary `cytoscape` released yet another semver breaking change, affecting typing once more in a couple of places. They now have their own `index.d.ts` file for Typescript support, but this causes some issues as they don't always have the same type name as the `@types` version. Had to fix in a couple of places, both in APM and in ML codebases. Supersedes elastic#206498 ## How to test * This PR passes the CI with no typing issues, or failed tests * Going to APM or ML pages with cytoscape being loaded shows no regressions.
Summary
cytoscape
released yet another semver breaking change, affecting typing once more in a couple of places. They now have their ownindex.d.ts
file for Typescript support, but this causes some issues as they don't always have the same type name as the@types
version. Had to fix in a couple of places, both in APM and in ML codebases.Supersedes #206498
How to test